search

JesusFreke / smali

smali/baksmali
6.29k stars 1.07k forks source link

Fixing METHOD_PROTO and DualReferenceInstruction writing via DexPool/ClassPool #818

Closed andvgal closed 2 years ago

andvgal commented 3 years ago

If some class with methods which use invoke-polymorphic is rewritten via dexlib2 then it leads to exception.

The cause of missing reference in pool is self-explanatory from the changes.

Related: https://github.com/JesusFreke/smali/issues/538#issuecomment-318557593

andvgal commented 3 years ago

@JesusFreke would you have chance to review, merge and release that?

andvgal commented 3 years ago

Hi @JesusFreke @Lanchon . Is there any chance you would look into this PR?

JesusFreke commented 2 years ago

I think these changes were all merged as part of your other PR.

andvgal commented 2 years ago

@JesusFreke unfortunately, that commit has broken authorship trail. Please fix that, if the original author was not able to.

JesusFreke commented 2 years ago

Oh, sorry. I thought that was your PR for some reason. I'll see if I can fix it up, and do a history rewrite and forced push.

JesusFreke commented 2 years ago

Ok, history rewritten :) Hopefully nobody synced in the meantime. heh

andvgal commented 2 years ago

Thank you very much!