search

JesusFreke / smali

smali/baksmali
6.29k stars 1.07k forks source link

added support for Rewriting instruction 45cc and METHOD_PROTO #836

Closed sriteja777 closed 2 years ago

sriteja777 commented 2 years ago

@JesusFreke Can you please review the PR?

andvgal commented 2 years ago

See also https://github.com/JesusFreke/smali/pull/818

andvgal commented 2 years ago

@sriteja777 you have basically taken my changes and overwritten the commit authorship

sriteja777 commented 2 years ago

@andvgal, sorry for that. I had a problem with an app, then your PR #818 helped me to solve that to some extent. Then I have made some changes on top of it. As I can't push those changes to your PR, I created a new PR for it. I had no intention to overwritten the commit authorship.

Let me know if there is any way to preserve the ownership :)

andvgal commented 2 years ago

@sriteja777 you can take the latest master, cherry-pick my change and then rebase this PR on top of such branch. Then my commit should be there right before yours.

JesusFreke commented 2 years ago

Looks good. Thanks! Sorry for the delay!