search

JesusTheHun / storybook-addon-remix-react-router

Use your app router in your stories. A decorator made for Remix React Router and Storybook
Apache License 2.0
45 stars 11 forks source link

updated StoryRouter to use recommended data router #20

Closed hugofelp closed 1 year ago

hugofelp commented 1 year ago

Attempt to fix issues related to new data routers: https://github.com/JesusTheHun/storybook-addon-react-router-v6/issues/19

afn commented 1 year ago

@JesusTheHun Can you merge this in? 🙏

JesusTheHun commented 1 year ago

@afn No. This PR breaks many things and does not port the current features to the new router. I'm working on a proper implementation.

afn commented 1 year ago

Ah okay. Meanwhile if anyone wants to use the forked package:

yarn add -D storybook-addon-react-router-v6@cygnuseducation/storybook-addon-react-router-v6

(I had to add a prepare script to allow the package to be installed from git — see 0130cd4455d0c2c714f1b20e0b31022c2fb9254f)

JesusTheHun commented 1 year ago

I'm closing this as my implementation is now complete.