search

JesusTheHun / storybook-addon-remix-react-router

Use your app router in your stories. A decorator made for Remix React Router and Storybook
Apache License 2.0
45 stars 11 forks source link

Typescript typings not setup ? #22

Closed VasilyShelkov closed 1 year ago

VasilyShelkov commented 1 year ago

Hi great work on the library. Is there something I'm missing here ? or is there a type definition file missing or the path in the package.json incorrectly set ? I'm having typescript issues with the package (at version 0.3.0 but couldn't get it to work with 0.2.2 either)

Screenshot 2023-03-14 at 13 53 40
JesusTheHun commented 1 year ago

Hello, version 0.2.2 is a mistake, it's exactly the same as 0.3.0. Can you try with 0.2.1? What is your initial issue? You can't install the package in a typescript project?

BenjaminHoch-GoTo commented 1 year ago

I guess he has the same issue i have after I tried to upgrade to 0.3.0: my IDE (VSC) complains about missing declaration file: Could not find a declaration file for module 'storybook-addon-react-router-v6'. '/Users/username/pathToProject/node_modules/storybook-addon-react-router-v6/dist/cjs/index.js' implicitly has an 'any' type.

going back to 0.2.1 error is gone and the folder and file structure looks different: image

JesusTheHun commented 1 year ago

Thanks for raising the issue. This has been fixed with version 0.3.1

BenjaminHoch-GoTo commented 1 year ago

Awesome quick solution. will upgrade now. Thank you!