Support for stable @storybook package versions

JesusTheHun / storybook-addon-remix-react-router

Use your app router in your stories. A decorator made for Remix React Router and Storybook

Apache License 2.0

50 stars 12 forks source link

Support for stable @storybook package versions #31

Closed bartelemi closed 1 year ago

bartelemi commented 1 year ago

Peer dependencies are too strict and currently do not allow using stable version of @storybook packages.

npm ERR! Found: storybook-addon-react-router-v6@0.3.5
npm ERR! node_modules/storybook-addon-react-router-v6
npm ERR!   dev storybook-addon-react-router-v6@"1.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! dev storybook-addon-react-router-v6@"1.0.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @storybook/theming@7.0.10
npm ERR! node_modules/@storybook/theming
npm ERR!   peer @storybook/theming@"^7.0.0-rc.3" from storybook-addon-react-router-v6@1.0.0
npm ERR!   node_modules/storybook-addon-react-router-v6
npm ERR!     dev storybook-addon-react-router-v6@"1.0.0" from the root project

JesusTheHun commented 1 year ago

Can you share what version you use ? @storybook/* and the addon.

bartelemi commented 1 year ago

Apologies for raising this issue, turns out it was a problem with my local node_modules/ directory which somehow got corrupted. npm was assuming that there are some incompatible deps and started throwing errors.

However, I still think it's better to rely on stable versions of libraries when available (non release-candidates), so in my opinion the peer dependencies of your package would benefit from being updated.

Having said that, feel free to close this issue as it is actually resolved.

Neurrone commented 1 year ago

I'm facing the same issue. Peer dependency resolution is breaking since this package specifies the rc version of various storybook packages.

pinetree commented 1 year ago

Yes, facing the same. @JesusTheHun

I.e.

npm ERR! Could not resolve dependency:
npm ERR! peer @storybook/components@"^7.0.0-rc.3" from storybook-addon-react-router-v6@1.0.0
npm ERR! node_modules/storybook-addon-react-router-v6
npm ERR!   dev storybook-addon-react-router-v6@"^1.0.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @storybook/components@7.0.12
npm ERR! node_modules/@storybook/components
npm ERR!   peer @storybook/components@"^7.0.0-rc.3" from storybook-addon-react-router-v6@1.0.0
npm ERR!   node_modules/storybook-addon-react-router-v6
npm ERR!     dev storybook-addon-react-router-v6@"^1.0.0" from the root project

I'm using the latest version of the storybook, 7.0.12.

noveogroup-amorgunov commented 1 year ago

Same problem :(

JesusTheHun commented 1 year ago

@Neurrone @pinetree @noveogroup-amorgunov Can you try this version and tell me if it resolves the issue :

npm i -D storybook-addon-react-router-v6@1.0.1--canary.a8c156e.0
yarn add -D storybook-addon-react-router-v6@1.0.1--canary.a8c156e.0

noveogroup-amorgunov commented 1 year ago

@JesusTheHun hello, no changes. But I'm not sure what the problem in this package

JesusTheHun commented 1 year ago

Your issue seems to come from react-inspector. Can you try version storybook-addon-react-router-v6@1.0.1--canary.e7845b3.0 ?

noveogroup-amorgunov commented 1 year ago

@JesusTheHun now it's all okay, thanks

JesusTheHun commented 1 year ago

@bartelemi @noveogroup-amorgunov @pinetree @Neurrone Dependencies have been updated with version 1.0.1

EldinZaimovic commented 8 months ago

I am facing same/similar issue with storybook 8

Could not resolve dependency:
npm ERR! peer @storybook/blocks@"^8.0.0" from storybook-addon-remix-react-router@3.0.0
npm ERR! node_modules/storybook-addon-remix-react-router
npm ERR!   dev storybook-addon-remix-react-router@"3.0.0" from the root project

JesusTheHun commented 8 months ago

@EldinZaimovic this is unrelated, @storybook/blocks is a peer dependency so you must install it as part of your project.