search

JetBrains-Research / RefactorInsight

An IntelliJ IDEA plugin that detects refactorings in Git commits
https://plugins.jetbrains.com/plugin/14704-refactorinsight
MIT License
104 stars 11 forks source link

refactorings.xml is not part of .idea/.gitignore #112

Closed mikhail-putilov closed 1 year ago

mikhail-putilov commented 1 year ago

Hi,

Today I realized that I am committing a file with my local filesystem paths into a common repo because .idea/.gitignore does not include refactorings.xml as ignorable file.

image image

onewhl commented 1 year ago

@mikhail-putilov thank you very much! We will try to fix it and then I will get back to you.

dimonchik0036 commented 1 year ago

Probably the right solution here is not to add this file to gitignore, because it still will annoy users. I think you shouldn't introduce a new storage, because, as far as I understand, the file is not supposed to be shared with team members. So, either at least the storage should be marked as RoamingType#DISABLED, or StoragePathMacros#WORKSPACE_FILE or StoragePathMacros#CACHE_FILE should be used instead of the custom storage.

onewhl commented 1 year ago

@dimonchik0036 thank you, I've fixed it as you suggested! @mikhail-putilov fix will come in the next plugin release. After updating, please, just remove this file "refactorings.xml", it will not be needed.