JetBrains-Research / jbr

JBR Genome Browser
https://doi.org/10.1093/bioinformatics/btab376
11 stars 0 forks source link

New session is appended to existing one ignoring new session panels structure #260

Open iromeo opened 11 months ago

iromeo commented 11 months ago

The new session is appended to existing one w/o panels. PR (https://github.com/JetBrains-Research/epigenome/pull/1530) adds panels serialization into Session file (https://github.com/JetBrains-Research/jbr/issues/248).

If some tracks are already shown in JBR, JBR suggests appending a new session to the existing one. If the user accepts suggestion (press No) and allow to append his multi-panel session, all tracks will be added to the last panel. Seems better is to

image

Xewar313 commented 11 months ago

I am not entirely convinced if adding panels to the end of session is a good idea - let's assume that we have a session with 3 panels, and a second session with additional 3 panels. That would result in a session with 6 panels, and these panels would be quite small, and almost unusable. Are you sure we want to implement it that way?

iromeo commented 11 months ago

Agree, need to brainstorm a bit more