Span peak scores - Githubissues

JetBrains-Research / span

SPAN Semi-supervised Peak Analyzer

https://doi.org/10.1093/bioinformatics/btab376

MIT License

9 stars 1 forks source link

Span peak scores #16

Closed dievsky closed 5 years ago

dievsky commented 5 years ago

Previously, peak value (coverage score / fold change) was only calculated and reported when invoked from JBR. With this pull request, peak value is reported if Span finds all relevant coverage cache files. If it doesn't, a debug message is logged, and the value is reported as 0.0 (like it is now).

Rationale: if the user obtained just a model file (e.g. by downloading or copying), we should let them call peaks from it, even though there's no access to the coverage data.

dievsky commented 5 years ago

See issue #15 .

olegs commented 5 years ago

Can we please TestCase on non-zero scores?

dievsky commented 5 years ago

@olegs please see https://github.com/JetBrains-Research/span/pull/16/commits/f4a858dffe05d0bb75469977557b7155126cc96c . If it's not enough, please let me know.

olegs commented 5 years ago

Yep, I didn't see the file name, I thought that is was DEBUG message in regular code.