search

JetBrains-Research / viktor

Efficient f64-only ndarray in Kotlin
MIT License
125 stars 6 forks source link

F64FlatArray::copy should return F64FlatArray #29

Closed altavir closed 3 years ago

altavir commented 4 years ago

I am not sure it is a frequent use-case, but it costs nothing to override the method.

dievsky commented 4 years ago

I was actually thinking of hiding the type hierarchy completely, leaving only the base F64Array class public, since the implementation specifics aren't really relevant for the user.

dievsky commented 3 years ago

Summary: just two types are now public, F64Array and F64FlatArray. copy() returns the correct type. Other types are now internal. Will close after the release.

dievsky commented 3 years ago

Resolved in the release candidate 1.1.0-rc-1.