search

JetBrains-Research / viktor

Efficient f64-only ndarray in Kotlin
MIT License
125 stars 6 forks source link

Consider removing special-cased subclasses #5

Closed superbobry closed 8 years ago

superbobry commented 8 years ago

Maybe a single generic StridedMatrix with special-cased get/set would be enough? This could also simplify #4.

superbobry commented 8 years ago

Done. We now have a single matrix class F64Matrix.

I've decided to keep F64Vector, although it too can be embedded within F64Matrix, for the purpose of readability: overloaded getters and setters look much less clear than get(Int) and set(Int). We might want to drop it at some point in the future.