search

JetBrains / Exposed

Kotlin SQL Framework
http://jetbrains.github.io/Exposed/
Apache License 2.0
8.28k stars 690 forks source link

fix: EXPOSED-390 ASC_NULLS_LAST and DESC_NULLS_FIRST for MySQL string columns #2091

Closed zly2006 closed 4 months ago

zly2006 commented 4 months ago

Hi @zly2006 Thanks for the PR! Looks good, just need to relocate the new test to a different file.

Could you please instead place the test (and its table) in shared/dml/OrderByTests.kt?

OK. I assumed that the database keeps the order for string like "b" and "B", gonna remove the uppercase test case.

zly2006 commented 4 months ago

OK all tests passed https://exposed.teamcity.com/buildConfiguration/Exposed_Build/5920?buildTab=tests&focusLine=NaN&name=testNullableStringOrdering

zly2006 commented 4 months ago

@bog-walk i have adopted these test. please see the build log, the unit tests passed on all databases.