JetBrains / ExternalAnnotations

JetBrains ReSharper External Annotations
https://www.jetbrains.com/help/resharper/Code_Analysis__External_Annotations.html
MIT License
81 stars 44 forks source link

List.RemoveAll annotation is absent on .NET Core #167

Closed ForNeVeR closed 5 years ago

ForNeVeR commented 5 years ago
  1. Create .NET Core project
  2. Write the following code: new List<int>().RemoveAll(x => true)
  3. Check Quick Docs for the RemoveAll method

Expected result: [InstantHandle] should be shown, because it is specified in this repository Actual result: no annotations shown

At the same time, if I create the .NET Framework project, I can see the InstantHandle and the CollectionAccess annotation as if .NET Framework annotation was combined with .NET Core one.

Also it seems wrong that .NET Core and .NET Framework versions of RemoveAll method have different annotations. We probably should unify them.

ForNeVeR commented 5 years ago

Actually, .NET Core 2.2 defines List class in the System.Private.CoreLib assembly, and it should have all the proper annotations according to this repo.