search

JetBrains / ExternalAnnotations

JetBrains ReSharper External Annotations
https://www.jetbrains.com/help/resharper/Code_Analysis__External_Annotations.html
MIT License
81 stars 44 forks source link

Mark ExceptionDispatchInfo::Throw() as "always throw" #17

Closed ViIvanov closed 7 years ago

ViIvanov commented 8 years ago

This method always throws an exception: http://referencesource.microsoft.com/#mscorlib/system/runtime/exceptionservices/exceptionservicescommon.cs,fc3b312e2d0ab87a

But R# does not know about it: image

// I will try to send PR for this

derigel23 commented 8 years ago

It's already marked with necessary annotation https://github.com/JetBrains/ExternalAnnotations/blob/8b9d8a1726ba096dc7fdf3deda4cb8dbfd1bb787/Annotations/.NETFramework/System/Attributes.xml#L12

derigel23 commented 8 years ago

@ViIvanov, issue is not related to external annotations - please file an issue in ReSharper tracker.

derigel23 commented 8 years ago

Oh, and it's not ReSharper's issue at all.

chrisoverzero commented 7 years ago

@derigel23 I think you did not read this ticket carefully. Debug.Fail is not the method in question. It is ExceptionDispatchInfo#Throw. (That is, the instance method Throw.) You have linked to the annotation for Debug.Fail.

derigel23 commented 7 years ago

@chrisoverzero agree. That's why PR is always better :)