search

JetBrains / JetBrainsMono

JetBrains Mono – the free and open-source typeface for developers
https://jetbrains.com/mono
SIL Open Font License 1.1
10.82k stars 302 forks source link

Ligature request for ~= (for Lua) #166

Closed rafaskb closed 11 months ago

rafaskb commented 4 years ago

When programming Lua, the not equals operator is ~=. It would be nice to have a ligature transforming it into ≃.

And congratulations for the font, it's a pleasure to work with it. :)

philippnurullin commented 4 years ago

@rafaskb Hi. Glad to hear that you enjoying it. Can you send the screenshots with this ligature in context of the code? I believe we have it already.

rafaskb commented 4 years ago

@philippnurullin Yeah sure! Here it is, with two fonts for comparison:

lua not equals jetbrains mono

I'm using version 1.0.3

philippnurullin commented 4 years ago

@rafaskb Are the other ligatures present? Can you type something like => -> === & send screenshot of them?

rafaskb commented 4 years ago

@philippnurullin Yeah, all ligatures seem to work just fine.

lua ligatures

philippnurullin commented 4 years ago

@rafaskb What IDE you using? In DejaVu Sans used a different approach to ligatures. Can you also try the latest Fira Code, to see if this error is persistent?

rafaskb commented 4 years ago

@philippnurullin I'm using IntelliJ IDEA 2019.3.1 and macOS 10.14.4 with the latest JetBrains Mono font installed into the system.

I just downloaded the latest FiraCode release from Github and confirmed it works just fine with it. Here's a screenshot:

image

philippnurullin commented 4 years ago

@rafaskb Looks like you working on older bundled version of the font which don't have this ligature. You need to manually remove it from IDEA. The locations can be found in this issue. https://github.com/JetBrains/JetBrainsMono/issues/142 Let me know if this helps or not.

rafaskb commented 4 years ago

Oh that makes perfect sense. Disabling the bundled font and using the OS one solves the issue. I'm sorry for the trouble, I didn't realize I was already using a recent version of the IDE with the font bundled.

Now the ~= ligature works as expected, and it's looking good! :)

rafaskb commented 3 years ago

After updating IntelliJ to 2020.3, this specific ligature doesn't work anymore. Other ligatures are working just fine though.

philippnurullin commented 3 years ago

Hi @rafaskb This ligature was removed after requests. Sorry can't find the exact issue for that.