JetBrains / JetBrainsMono

JetBrains Mono – the free and open-source typeface for developers
https://jetbrains.com/mono
SIL Open Font License 1.1
10.86k stars 301 forks source link

Emoji ⚠️ is not shown as emoji #450

Closed muuvmuuv closed 3 years ago

muuvmuuv commented 3 years ago

Using the Emoji "⚠️" in VS Code just displays a Unicode Symbol, even with a fallback font:

Bildschirmfoto 2021-05-27 um 14 03 32

I am aware that there was a previous discussion about monospaced fonts should not include Emoji support, but then why is this happening, and how can I prevent it?

philippnurullin commented 3 years ago

Hi @muuvmuuv It's happening because we added a ⚠️ symbol in the JB Mono.

To prevent it from happening you need to modify the font files. Delete the warningSign Uni-26A0. Ideally you need to have Glyphs app, so you can edit the source and build from it using scripts provided in Sources repository.

But here is a link to StackOverflow with other options https://stackoverflow.com/questions/12976424/how-to-remove-characters-from-a-font-file

philippnurullin commented 3 years ago

What is the advantage of using this Emoji? Maybe the glyph in JB Mono can be modified to match these criteria.

muuvmuuv commented 3 years ago

It isn't that mandatory for me so that I am willed to spend the time on modifying the font, but thanks for the hint, good reading!

The advantage for me and other project members would be that the yellowish Emoji stand out much more than the grey symbol.

philippnurullin commented 3 years ago

Increased the size of ⚠️as possible and made it black so it pop out more. You can grab the files from here https://github.com/JetBrains/JetBrainsMono/tree/master/fonts

fpopineau commented 2 years ago

Hi, Isn't that a bit strange to make this emoji black? I thought that the whole purpose of these emojis is to stand out with their classic (flashy) colors? Regards and thanks for the JetBrains fonts.

alexeyten commented 2 years ago

@fpopineau there is a good article about emoji https://tonsky.me/blog/emoji/

Especially see Variation selector-16 part

fpopineau commented 2 years ago

Thanks for the detailed information. Unfortunately, it seems that the variation selector 16 is not supported under Windows 10/11 :-/

Le sam. 30 juil. 2022 à 19:00, Alexey Ten @.***> a écrit :

@fpopineau https://github.com/fpopineau there is a good article about emoji https://tonsky.me/blog/emoji/

Especially see Variation selector-16 part

— Reply to this email directly, view it on GitHub https://github.com/JetBrains/JetBrainsMono/issues/450#issuecomment-1200256580, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOTV3ZH5QST7YAM6BBXXBTVWVNRRANCNFSM45UECGBQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Fabrice

alexeyten commented 2 years ago

I'm pretty sure it works on Windows, but it may not work in some applications.

fpopineau commented 2 years ago

Oh... I said that it is not supported because I found it on https://emojipedia.org/microsoft/windows-11-november-2021-update/variation-selector-16/ but I have no idea of the reliability of this source. Actually what I see on this page https://www.ii.com/unicode-variation-selectors-15-16/ makes me think it may be supported (or at least partly ?) So I played with it but I still don't understand if what I see with JetBrains Mono is correct or not. I duplicated one of the rows to add an example with entity ⚠ Then I changed the font-family for

With JetBrains Mono I see : image

With Source Code Pro (and many other fonts not providing the :warning: glyph/emoji) I see: image

So it seems that because JetBrains Mono is providing the glyph, the selector does not switch to another "emoji" font. Am I right or am I missing something? And is it what is expected?

Thanks for your help.

Le dim. 31 juil. 2022 à 09:18, Alexey Ten @.***> a écrit :

I'm pretty sure it works on Windows, but it may not work in some applications.

— Reply to this email directly, view it on GitHub https://github.com/JetBrains/JetBrainsMono/issues/450#issuecomment-1200365657, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOTV3ZWOPBTFDSUHR4CIK3VWYSDBANCNFSM45UECGBQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Fabrice

alexeyten commented 2 years ago

@fpopineau images in your answer are missing. Please answer from github website.

fpopineau commented 2 years ago

@fpopineau images in your answer are missing. Please answer from github website.

Sorry. I have edited the message above.

alexeyten commented 2 years ago

Looks like Chromium-based browsers have a bug https://bugs.chromium.org/p/chromium/issues/detail?id=964527

Firefox Firefox screenshot

Chromium-based Browser Chromium-based Browser screenshot

Test page

KotlinIsland commented 2 years ago

The latest EAP supports variation selector 15/16 for emoji characters. https://youtrack.jetbrains.com/issue/JBR-4832/Support-Variation-Selectors-in-text-rendering-for-emojies