search

JetBrains / JetBrainsMono

JetBrains Mono – the free and open-source typeface for developers
https://jetbrains.com/mono
SIL Open Font License 1.1
10.86k stars 301 forks source link

Fix #454 #464

Closed alexeyten closed 3 years ago

alexeyten commented 3 years ago

Classic sh doesn't have source command. It's bash (and some other shells) specific. The original command is . (yes, just dot)

philippnurullin commented 3 years ago

Hello @alexeyten. Looks like the modification is breaking the build-vf.sh. Sorry, can't merge it.

alexeyten commented 3 years ago

Looks like it just reveal a bug. source env/bin/activate never works because shell couldn't find command source. See e.g. https://github.com/JetBrains/JetBrainsMono/runs/2628563730?check_suite_focus=true#step:7:6. But it didn't fail build because set -e command went after this line.

After replacing source with . script fails because it cannot find file env/bin/activate.

I've fixed this with checking if file exists before .-ing it.

philippnurullin commented 3 years ago

Yes, it fails in the right places now. ))) Thanks!

@RosaWagner Maybe it will be useful. If not sorry for poking.