JetBrains / JetBrainsMono

JetBrains Mono – the free and open-source typeface for developers
https://jetbrains.com/mono
SIL Open Font License 1.1
10.58k stars 298 forks source link

Warning When Building From Source #500

Closed p0da closed 2 years ago

p0da commented 2 years ago

It looks like there is an warning when building from source: WARNING:gftools.fix:Cannot remove tables '['MVAR'] Seems to be related to this. Is this to be expected or is there a fix?

philippnurullin commented 2 years ago

The original text of the warning: WARNING:gftools.fix:Cannot remove tables '['MVAR']' since they are not in the font. So the script want to delete the MVAR but it returns warning because there is nothing to delete. So basically everything is fine / works as expected.

The code you referring to is a legacy that is not used anymore. Need to delete it by the way. Thanks for bringing that up.

If you have questions regarding how building script works I suggest ask the creator. https://github.com/JetBrains/JetBrainsMono/pull/490

p0da commented 2 years ago

Thanks for the confirmation, I figured as much just wanted to verify.