search

JetBrains / JetBrainsMono

JetBrains Mono – the free and open-source typeface for developers
https://jetbrains.com/mono
SIL Open Font License 1.1
10.57k stars 299 forks source link

Ligatures + git diffs #538

Closed gf3 closed 1 year ago

gf3 commented 2 years ago

i don't know enough about building fonts to know if this is correctable, however when ligatures are enabled git diff separators appear a little unnatural:

Emacs payments.go – Doom Emacs 2022-04-19 at 11.20.46

<<<<<<< HEAD
=======
    "github.com/kamva/mgm/v3"
    "go.mongodb.org/mongo-driver/bson"
    "go.mongodb.org/mongo-driver/mongo"

    "freshline.io/octograph/pkg/graph/model"

>>>>>>> 2130ba83a (add payment on client)
trygveaa commented 2 years ago

Which version are you using? I'm using 2.242 and it looks fine for me, as in the ligatures are disabled when there's more than three < or = following each other.

gf3 commented 2 years ago

@trygveaa i'm using the latest release from the website as of last week. and i'm using it with emacs without any special font configuration or settings:

(font-spec :family "JetBrains Mono" :size 14 :weight 'light :height 1.3)
philippnurullin commented 2 years ago

Hi @gf3 . I'm unable to reproduce this issue in 2.242.

To make sure you have this version please

gf3 commented 2 years ago

@philippnurullin i did as requested and i'm still experiencing the issue. however after some testing i believe my editor is somehow forcing ligatures because when i disabled all language features it appears correctly:

GIF

philippnurullin commented 2 years ago

Hi again @gf3 . The code for ligature consists from simple rules. There is a rule that breaks the ligature in certain conditions. Looks like this part of the instructions is not working in emacs case. The possible solutions I see are: