JetBrains / JetBrainsMono

JetBrains Mono – the free and open-source typeface for developers
https://jetbrains.com/mono
SIL Open Font License 1.1
10.57k stars 299 forks source link

tilde + dash glyph combination is odd with ligatures #556

Closed kajukenbo closed 1 year ago

kajukenbo commented 1 year ago

~ + - or - + ~ i.e ~ - & - ~ without spaces Combination looks oddly compressed (and "ugly") in XFCE Mousepad (GNU/Linux text editor) if using the ligature version of the fonts. I cannot tell if it is due to the ligatures, spacing or something else. It seems to happen always in xfce4-terminal without the NL variant but I have not done a lot of testing in other apps.

The NL version of the fonts seem to be fine. v2.242 (Latest) for the record

shahmilav commented 1 year ago

Edit: I didn't see your edit, your original comment mentioned that it doesn't happen in xfce4-terminal, so this comment goes on that belief

That is because of the ligatures. xfce-terminal does not support ligatures, so that is why the ligature does not appear.

See the comparison below (terminal used is iTerm2)

No ligatures (see checkbox on the bottom right)

Screen Shot 2022-09-01 at 10 33 04 PM

Yes ligatures (see checkbox on the bottom right)

Screen Shot 2022-09-01 at 10 32 58 PM
kajukenbo commented 1 year ago

As I stated & suspected, but your suggestion does not solve the issue with editors (or terminal emulators) that do not support ligatures.

I would expect the "normal" font to fall-back to a "no ligature" variant if the rendering engine did not support ligatures in the first place.

I will just switch to a different font for now.

Thanks

shahmilav commented 1 year ago

@kajukenbo could you please give examples of editors/terminals you tried? Specifically those that do not support ligatures but still show the glyph. Also, could you share a screenshot of XFCE terminal with the glyph?

I would expect the "normal" font to fall-back to a "no ligature" variant if the rendering engine did not support ligatures in the first place.

AFAIK, the NL variant only differs from the Standard variant in that the NL variant does not have ligatures. (I'm not a font developer, so don't quote me on this)

Therefore, if the application does not support ligatures, JBM won't use ligatures (they are unsupported) and will be identical to the NL variant.

philippnurullin commented 1 year ago

@kajukenbo

I would expect the "normal" font to fall-back to a "no ligature" variant if the rendering engine did not support ligatures in the first place.

Unfortunately, font doesn't have that ability. This behaviour is on the application side.

As you suggested, the solution is to use NL version.