Support PlantUML ligatures

JetBrains / JetBrainsMono

JetBrains Mono – the free and open-source typeface for developers

https://jetbrains.com/mono

SIL Open Font License 1.1

10.58k stars 299 forks source link

Support PlantUML ligatures #92

Open erikhuizinga opened 4 years ago

erikhuizinga commented 4 years ago

PlantUML uses various kinds of arrows and other syntactic symbols. See the PlantUML guide for all syntax. Suggestion: support these character combinations as ligatures.

Two examples are PlantUML arrows that I came across. They don't work well with Mono's ligatures:

-|>
--|>

They render like so:

yvvt0379 commented 1 year ago

Sorry to ask, is PlantUML ligatures still under construction?

philippnurullin commented 1 year ago

@CodeCrazy-ywt thanks for the question. It's not in priority.

I feel like the PlantUML is fairly not very popular software.
The PlantUML guid is 417 pages long, and it seems like a big investment.
I see a potential issues with https://github.com/JetBrains/JetBrainsMono/issues/256 which is requested more.

erikhuizinga commented 1 year ago

Not sure, but maybe some of the Fira Code style arrow ligatures cover the PlantUML operators? If that's the case, then that would help already by rendering a nicer glyph than the ones that I show in https://github.com/JetBrains/JetBrainsMono/issues/92#issue-554720470. So that would increase the priority to solve #256 a little.

philippnurullin commented 1 year ago

Unfortunately not. The current implementation of infinity arrows in Fira produces the same issues you mentioned above.

What could really help if someone made an extraction of potential ligatures from PlantUML. For the beginning, it can be just few ones.

erikhuizinga commented 1 year ago

https://github.com/plantuml/plantuml/issues/1150

erikhuizinga commented 1 year ago

An answer with a non-exhaustive list of arrows in PlantUML: https://github.com/plantuml/plantuml/issues/1150#issuecomment-1266942034.