JBR-6696: hardened MTLGC_DestroyMTLGraphicsConfig

JetBrains / JetBrainsRuntime

Runtime environment based on OpenJDK for running IntelliJ Platform-based products on Windows, macOS, and Linux

GNU General Public License v2.0

1.28k stars 193 forks source link

JBR-6696: hardened MTLGC_DestroyMTLGraphicsConfig #301

Closed bourgesl closed 3 months ago

bourgesl commented 7 months ago

to ensure any aync callbacks are performed before deallocation, added CVDisplayLink checks, traces and refactored cleanup code + fixed review comments

bourgesl commented 7 months ago

Will fix PR asap

avu commented 7 months ago

Did you check for freezes that happened with the previous version?

bourgesl commented 7 months ago

Yes I am testing my patch ...

bourgesl commented 7 months ago

(WIP) tests in progress... still annoying trouble with (not direct surface) when scaling factor are changed and new frame created...

bourgesl commented 3 months ago

New PR opened: https://github.com/JetBrains/JetBrainsRuntime/pull/383