Closed mkartashev closed 8 months ago
The test test/jdk/jb/build/CDSArchivesTest.sh
currently checks that jsa-files were included into jbrsdk-distributions, but after these changes jsa-files will be included into both distributions jbr and jbrsdk. The test should be modified to check both distributions.
windows-aarch64 do not have jsa-files in spite of the option --generate-cds-archive
.
Note: for windows these files should be in bin/server
(not in lib/server
)
I suspect the issue with windows-aarch64 is originated from Microsoft - I was going to submit this issue to JBS
...after these changes jsa-files will be included into both distributions jbr and jbrsdk. The test should be modified to check both distributions.
I'm not sure this is the case; if they are included into jbr also, I would prefer to remove them rather than to modify the test. As per our earlier agreement, CDS archives only make sense for jbrsdk.
This commit does not add CDS to jbr bundles and does not create CDS files on Windows/aarch64. Please, take a look: https://github.com/JetBrains/JetBrainsRuntime/pull/303/commits/bc239df27eac50caf5d5d347d34084821e4e5ef6
IMPLEMENTOR_VERSION is incorrectly defined in Linux so the test wrongly fails
Merged
The CDS files (
*.jsa
) are created with the option--generate-cds-archive
ofjlink
. Themodules
file at their creation time must be the same at run time; so when they are overwritten with the files from$IMAGES_DIR
wheremodules
is different, we get a warning at run time when those CDS files are used. The fix is to not overwrite*.jsa
files after they were created.