search

JetBrains / JetBrainsRuntime

Runtime environment based on OpenJDK for running IntelliJ Platform-based products on Windows, macOS, and Linux
GNU General Public License v2.0
1.35k stars 198 forks source link

JBR-7194: extension-based filters in native file dialogs #386

Closed trespasserw closed 5 months ago

trespasserw commented 6 months ago

Adding an ability to set simple file-extension-based filters for file dialogs. While being less flexible than FileDialog#setFilenameFilter, extension-based filters don't require callbacks to Java code and are supported on all platforms.

avu commented 6 months ago

@trespasserw It would be nice to have a regression test for this feature (something like test/jdk/jb/javax/swing/CustomTitleBar/JFrameNativeControlsMacOSTest.java). It can be created even for incomplete implementation using the platform tag in the jtreg test case.

vprovodin commented 6 months ago

Should the ticket IJPL-150176 be moved into the JBR YT project?

trespasserw commented 6 months ago

@vprovodin what are those commits? upd: got it

IJPL-150176 should not be moved, but I will create a companion ticket in JBR later today and edit commit messages upd: done

YaaZ commented 6 months ago

LGTM. As discussed, we are not going to merge it right away, it will go into the next major JBR API update

YaaZ commented 5 months ago

Pushed to main for now

YaaZ commented 5 months ago

Pushed this to main, jbr17, jbr21, so closing the review