JBR-5956 Provide more details on assertion failure

JetBrains / JetBrainsRuntime

Runtime environment based on OpenJDK for running IntelliJ Platform-based products on Windows, macOS, and Linux

GNU General Public License v2.0

1.32k stars 196 forks source link

JBR-5956 Provide more details on assertion failure #415

Closed mkartashev closed 2 months ago

mkartashev commented 3 months ago

JBR-5956 Provide more details on assertion failure

Use JNU_RUNTIME_ASSERT(env, cond, msg) defined in jni_util.h to crash JVM when cond is not true with the given message and source location information in the fatal error log.

vprovodin commented 3 months ago

do we need a hotspot test checking this functionality?

mkartashev commented 3 months ago

do we need a hotspot test checking this functionality?

Not an easy thing to accomplish. I will look into this.

mkartashev commented 3 months ago

I managed to add a test that verifies at least the core functionality. Please, have a look.