search

JetBrains / MPS-extensions

MPS-extensions aims to ease language development within MPS.
https://jetbrains.github.io/MPS-extensions/
Apache License 2.0
82 stars 51 forks source link

celllayout: editor doesn't show the full node vertically #681

Closed alamqadem closed 2 months ago

alamqadem commented 11 months ago

Description

Given an indent collection containing an horizontal collection, if the internal collection is large enought this is reported on a new line.

image

Now after a certain size the editor doesn't display the full node, in fact the scroll-bar doesn't allow to scroll down to see the last part of the node. I suspect that the height of the resulting node it's not calculated correctly (RootConcept).

image

Disabling the LayoutInterceptor the node is shown correctly.

image

Reproducer

I've attached a reproducer in the following branch bug/celllayout-cell-height-not-correct based on maintenance/mps20213.

alamqadem commented 11 months ago

Using the Editor Cell Explorer I can check the height calculated for the cell with the LayoutInterceptor on, which is 84.

And without the interceptor active, I get 105.

alexanderpann commented 2 months ago

Not reproducible anymore. This issue was fixed a while ago.