Closed alexanderpann closed 7 months ago
The PR has some diff also for the statistics plugin and the de.slisson.tables packages. Is this intended? They are not mentioned in the description.
The PR has some diff also for the statistics plugin and the de.slisson.tables packages. Is this intended? They are not mentioned in the description.
I've executed Force save all at the end because some resolve infos were not up to date.
What is the purpose of this comment:
Is this getAscent relevant for the PR? The number seems somewhat arbitrary. Node url: http://127.0.0.1:63320/node?ref=r%3A4f2e39b1-e20e-479e-9e71-d33f8c6766e2%28de.itemis.mps.editor.pagination.runtime.ui%29%2F4421291014783892042
As the comment says, the horizontal positioning of the swing component didn't work, so I had to position it manually. I couldn't figure out the right formula, so I had to hardcode the value.
As the comment says, the horizontal positioning of the swing component didn't work, so I had to position it manually. I couldn't figure out the right formula, so I had to hardcode the value.
Ok, thanks for the clarification. This might be a bit nitpicky but just so that future readers see the reason for the number, can you update the comment accordingly, e.g. "Hardcode horizontal position of search bar since automatic computation does not work"?
Unfortunately, not mergeable yet because the performance is bad for big numbers of nodes.The performance issues already existed before this change. Not sure how we can fix them.