JetBrains / MPS-extensions

MPS-extensions aims to ease language development within MPS.
https://jetbrains.github.io/MPS-extensions/
Apache License 2.0
80 stars 47 forks source link

diagram.runtime.model: ModelSynchronizer - avoid unnecessary calls to fromSModel_Subdiagram for sub-diagrams #754

Closed danielratiu closed 5 months ago

danielratiu commented 5 months ago

We are using diagrams imbricated in other diagrams (sub-diagrams), image

The layout information for a subdiagram is already read when the object SubdiagramECell is created image

The ModelSynchronizer reads from SModel unnecessarily many times - this triggers many calls for imbricated diagrams. This PR removes the reccursive refreshing of sub-diagrams from model: image