search

JetBrains / MPS-extensions

MPS-extensions aims to ease language development within MPS.
https://jetbrains.github.io/MPS-extensions/
Apache License 2.0
80 stars 47 forks source link

Reduce code duplication in subclasses of ElkLayouter #853

Open alexanderpann opened 4 weeks ago

alexanderpann commented 4 weeks ago

Copied from https://github.com/JetBrains/MPS-extensions/pull/844#issuecomment-2151707715:

One things that we maybe can improve is to reduce the code duplication. I see that all the subclasses of ElkLayouter basically just copy all the properties for the layout algorithm. The is the LayoutMetaDataService that provides information about the available algorithms and their properties. Maybe we can make use of it and have a generic implementation. This would also have the benefit, that new properties in future version of ELK are then automatically available.