search

JetBrains / Qodana

📝 Source repository of Qodana Help
https://www.jetbrains.com/help/qodana
Apache License 2.0
389 stars 63 forks source link

Add --rm flag for docker commands and remove useless pull step #8

Closed NicolasCARPi closed 3 years ago

NicolasCARPi commented 3 years ago

Docker run commands need to have the --rm flag to avoid stopped containers piling up after several use.

Also, Docker will automatically pull the image when the run command is launched, so there is no need for this extra step of prealably pulling the image.

a-kuznetsova commented 3 years ago

Thank you for your suggestions. You are right, Docker will automatically pull the image when the run command is launched, but this will only happen during the first run. Since we want our users to have the latest version possible, we included the docker pull command to the Readme. Could you please mention this in the Readme next to the docker pull command?

Regarding the --rm flag, let's add it as you suggest :)

NicolasCARPi commented 3 years ago

@a-kuznetsova You're correct, the pull command is nice to have to get the latest version. I added --rm to CI commands too even if it's not strictly necessary as the whole thing has a short lifespan, but it's to be consistent. I removed the -it as it's not necessary. Also removed trailing whitespaces and added newline at end of file. And added the --rm on main README.