Build fails with the latest master branch on UE 4.27 on Linux by pulling in some Windows headers

[NuLL3rr0r]

0>Fixing inconsistent case in filenames.
0>Setting up Mono
0>Running command : Engine/Binaries/DotNET/UnrealBuildTool.exe MamadouArchivesEditor Linux DebugGame -buildscw
0>Using 'git status' to determine working set for adaptive non-unity build (/home/mamadou/dev/MamadouArchives).
0>Building MamadouArchivesEditor...
0>Performing 8 actions (16 in parallel)
0>[1/8] Compile Module.LiveCoding.cpp
0>[2/8] Link (lld) libUE4Editor-RiderSourceCodeAccess.so
0>In file included from /home/mamadou/dev/MamadouArchives/Engine/Intermediate/Build/Linux/B4D820EA/UE4Editor/Development/LiveCoding/Module.LiveCoding.cpp:2:
0>In file included from /home/mamadou/dev/MamadouArchives/Engine/Source/Developer/Windows/LiveCoding/Private/External/LC_API.cpp:4:
0>In file included from /home/mamadou/dev/MamadouArchives/Engine/Source/Developer/Windows/LiveCoding/Private/External/LC_ClientStartupThread.h:6:
0>In file included from /home/mamadou/dev/MamadouArchives/Engine/Source/Developer/Windows/LiveCoding/Private/External/LC_Thread.h:6:
0>In file included from Runtime/Core/Public/Windows/WindowsHWrapper.h:7:
0>/home/mamadou/dev/MamadouArchives/Engine/Source/Runtime/Core/Public/Microsoft/WindowsHWrapper.h(11,14): Error  : 'Microsoft/WindowsHWrapperPrivate.h' file not found
0>    #include "Microsoft/WindowsHWrapperPrivate.h"
0>             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
0>ld.lld: Error  : undefined symbol: FOptionalSize::Unspecified
0>>>> referenced by SlateStructs.h:17 (Runtime/SlateCore/Public/Types/SlateStructs.h:17)
0>>>>               /home/mamadou/dev/MamadouArchives/Engine/Plugins/Developer/RiderSourceCodeAccess/Intermediate/Build/Linux/B4D820EA/UE4Editor/Development/RiderSCA/Module.RiderSCA.cpp.o:(FNotificationInfo::FNotificationInfo(FText const&))
0>clang++: Error  : linker command failed with exit code 1 (use -v to see invocation)
0>1 error generated.
Build failed at 4:58:41 PM 

[NuLL3rr0r]

Also on Windows it fails with the following error:

CONSOLE: C:\Users\mamad\Desktop\dev\MamadouArchives\Engine\Build\BatchFiles\Build.bat  -Target=" MamadouArchivesEditor Win64 DebugGame" -Target="ShaderCompileWorker Win64 Development -Quiet" -WaitMutex -FromMsBuild 
0>Using 'git status' to determine working set for adaptive non-unity build (C:\Users\mamad\Desktop\dev\MamadouArchives).
0>Waiting for 'git status' command to complete
0>Building MamadouArchivesEditor and ShaderCompileWorker...
0>Using Visual Studio 2019 14.29.30148 toolchain (C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133) and Windows 10.0.19041.0 SDK (C:\Program Files (x86)\Windows Kits\10).
0>Building 2 actions with 16 processes...
0>  [1/2] UE4Editor-RiderSourceCodeAccess.dll
0>     Creating library C:\Users\mamad\Desktop\dev\MamadouArchives\Engine\Plugins\Developer\RiderSourceCodeAccess\Intermediate\Build\Win64\UE4Editor\Development\RiderSCA\UE4Editor-RiderSourceCodeAccess.suppressed.lib and object C:\Users\mamad\Desktop\dev\MamadouArchives\Engine\Plugins\Developer\RiderSourceCodeAccess\Intermediate\Build\Win64\UE4Editor\Development\RiderSCA\UE4Editor-RiderSourceCodeAccess.suppressed.exp
0>Module.RiderSCA.cpp.obj: Error  : LNK2019: unresolved external symbol "__declspec(dllimport) private: static float const FOptionalSize::Unspecified" (__imp_?Unspecified@FOptionalSize@@0MB) referenced in function "bool __cdecl RSCA::CheckExecutable(class FString const &)" (?CheckExecutable@RSCA@@YA_NAEBVFString@@@Z)
0>C:\Users\mamad\Desktop\dev\MamadouArchives\Engine\Plugins\Developer\RiderSourceCodeAccess\Binaries\Win64\UE4Editor-RiderSourceCodeAccess.dll: Error  : LNK1120: 1 unresolved externals
Build failed at 9:58:27 PM 

[DecoyRS]

Hi @NuLL3rr0r Regarding the first issue - it's not RiderSourceCodeAccess pulling in windows headers though, it's on LiveCoding side (idk why it's being build at all). RiderSourceCodeAccess shows the same issue both on Windows and Linux - can't find the FOptionalSize::Unspecified. And I've noticed you've already (quite some time ago >_>) submitted a PR to fix it. I'll check it right away and will try to figure out why it's building on my side alright w/o the mentioned SlateCore reference/

[NuLL3rr0r]

Thank you very much for merging the PR! I guess this one is coming from RirderLink as I've described here. So, this probably can be closed.