search

JetBrains / RiderSourceCodeAccess

Plugin for UE4 to user Rider for Unreal Engine as code editor
Apache License 2.0
110 stars 21 forks source link

add the missing bracket that causes build failure #32

Closed NuLL3rr0r closed 7 months ago

NuLL3rr0r commented 7 months ago

I am getting the following build error against the master. It turned out a open bracket is missing:

[1278/1420] Compile Module.RiderSourceCodeAccess.cpp
In file included from ../Plugins/Developer/RiderSourceCodeAccess/Intermediate/Build/Linux/x64/UnrealEditor/Development/RiderSourceCodeAccess/Module.RiderSourceCodeAccess.cpp:5:
/home/mamadou/dev/MamadouArchives/Engine/Plugins/Developer/RiderSourceCodeAccess/Source/RiderSourceCodeAccess/Private/RiderSourceCodeAccessor.cpp:117:2: error: non-member function cannot have 'const' qualifier
        const FCommandLineInfo PlatformAppAndArgs = GetPlatformAppAndArgs(ExecutablePath, Params);
        ^~~~~~
/home/mamadou/dev/MamadouArchives/Engine/Plugins/Developer/RiderSourceCodeAccess/Source/RiderSourceCodeAccess/Private/RiderSourceCodeAccessor.cpp:117:7: error: expected ';' after top level declarator
        const FCommandLineInfo PlatformAppAndArgs = GetPlatformAppAndArgs(ExecutablePath, Params);
             ^
             ;
/home/mamadou/dev/MamadouArchives/Engine/Plugins/Developer/RiderSourceCodeAccess/Source/RiderSourceCodeAccess/Private/RiderSourceCodeAccessor.cpp:117:68: error: use of undeclared identifier 'ExecutablePath'
        const FCommandLineInfo PlatformAppAndArgs = GetPlatformAppAndArgs(ExecutablePath, Params);
                                                                          ^
/home/mamadou/dev/MamadouArchives/Engine/Plugins/Developer/RiderSourceCodeAccess/Source/RiderSourceCodeAccess/Private/RiderSourceCodeAccessor.cpp:117:84: error: use of undeclared identifier 'Params'
        const FCommandLineInfo PlatformAppAndArgs = GetPlatformAppAndArgs(ExecutablePath, Params);
                                                                                          ^
/home/mamadou/dev/MamadouArchives/Engine/Plugins/Developer/RiderSourceCodeAccess/Source/RiderSourceCodeAccess/Private/RiderSourceCodeAccessor.cpp:118:2: error: expected unqualified-id
        if(!CheckExecutable(PlatformAppAndArgs.App))
        ^
/home/mamadou/dev/MamadouArchives/Engine/Plugins/Developer/RiderSourceCodeAccess/Source/RiderSourceCodeAccess/Private/RiderSourceCodeAccessor.cpp:125:2: error: expected unqualified-id
        if (!bResult)
        ^
/home/mamadou/dev/MamadouArchives/Engine/Plugins/Developer/RiderSourceCodeAccess/Source/RiderSourceCodeAccess/Private/RiderSourceCodeAccessor.cpp:131:2: error: expected unqualified-id
        return bResult;
        ^
/home/mamadou/dev/MamadouArchives/Engine/Plugins/Developer/RiderSourceCodeAccess/Source/RiderSourceCodeAccess/Private/RiderSourceCodeAccessor.cpp:134:1: error: extraneous closing brace ('}')
}
^
DecoyRS commented 7 months ago

Thank you @NuLL3rr0r I'm surprised no one has reported about it before!