search

JetBrains / TeamCity.SonarQubePlugin

A plugin for TeamCity server allowing you to configure and run SonarQube analysis from the CI
Apache License 2.0
53 stars 32 forks source link

Permission management #15

Closed axel3rd closed 9 years ago

axel3rd commented 9 years ago

Proposal for Capacity to manage (edit/remove) only by admin bug.

Granted on Permission.EDIT_PROJECT, so give the capacity to create a dedicated role.

The best could be to create/register a new specific permission, but not sure possible with TC 8.1 (update : not possible)

Linfar commented 9 years ago

Hi, Thank you for contributing and please excuse me for long response, I will comment changes inline

axel3rd commented 9 years ago

@Linfar : Hi, thanks for the feedback. PR updated to use this credential.

Linfar commented 9 years ago

@axel3rd I've merged your branch with 2 minor fixes: Internal ProjectID is expected in AuthUtil Edit actions should not be visible for upper projects without edit permission (eg a project admin has edit permission for a child project only while server is defined in a parent project)

Thanks a lot for contributing!

axel3rd commented 9 years ago

@Linfar : Thanks for fix (I'm very newbie in TeamCIty plugin dev ...).

Could the build #23 pinned ? The download link on home/readme.txt (.lastPinned) is build #20 => The documentation content about permission is not contained in this build).

Linfar commented 9 years ago

@axel3rd done

axel3rd commented 9 years ago

@Linfar Thanks