search

JetBrains / TeamCity.VSTest.TestAdapter

Apache License 2.0
30 stars 14 forks source link

Building with .NET Core SDK 2.2.200 fails with Could not find a test logger with AssemblyQualifiedName, URI or FriendlyName 'logger://teamcity/' #31

Closed flcdrg closed 5 years ago

flcdrg commented 5 years ago

.NET Core SDK 2.2.200 (which is included in Visual Studio 2019) changes how MSBuildToolsVersion is defined.

This presumably means that https://github.com/JetBrains/TeamCity.VSTest.TestAdapter/blob/master/TeamCity.VSTest.TestLogger/TeamCity.VSTest.TestAdapter.props needs updating to match the new Current value

flcdrg commented 5 years ago

This probably is more generally a requirement to support Visual Studio 2019

flcdrg commented 5 years ago

Presumably .NET Core SDK 2.1.600 will also be affected

danpowell88 commented 5 years ago

Just saw there was a commit to fix this, any idea when the nuget package will get released?

NikolayPianikov commented 5 years ago

@danpowell88 I hope today

NikolayPianikov commented 5 years ago

The package was uploaded to nuget.org as 1.0.15

flcdrg commented 5 years ago

This is still broken

danpowell88 commented 5 years ago

The fix worked for me

flcdrg commented 5 years ago

Apologies.. Turns out I'd upgraded to 1.0.14, not 15 :-(

jfloodnet commented 5 years ago

The issue affects running dotnet test in docker builds using microsoft/dotnet:2.1-sdk (as @flcdrg mentions it here