search

JetBrains / TeamCity.VSTest.TestAdapter

Apache License 2.0
30 stars 14 forks source link

#46 Unable to retrieve test parameters from parameterized xunit tests - adds a resultDisplayName attribute #47

Closed NikolayPianikov closed 7 months ago

NikolayPianikov commented 9 months ago

The TeamCity service message now looks like this:

##teamcity[testFinished name='TestProject1: TestProject1.ParametrizedTests.Parametrized2' duration='0' suiteName='TestProject1' testSource='C:\Projects\Abc\TestProject1\TestProject1\bin\Debug\net8.0\TestProject1.dll' displayName='TestProject1.ParametrizedTests.Parametrized2' resultDisplayName='TestProject1.ParametrizedTests.Parametrized2(param1: "Abc 0", param2: 0, param3: |[Data2 { StrVal = str 1, DoubleVal = 33 }, Data2 { StrVal = str 2, DoubleVal = 99 }|])' fullyQualifiedName='TestProject1.ParametrizedTests.Parametrized2' id='8fe290ae-d2bc-7069-b154-bba59e1d4f21' executorUri='executor://xunit/VsTestRunner2/netcoreapp' lineNumber='0' timestamp='2023-12-08T15:50:06.512+0000' flowId='7ffee9a4']
mchechulnikov commented 7 months ago

Hi @NikolayPianikov,

Many thanks to you for the PR! And sorry for the delay with answering/merging.

We are looking into the PR right now. We had a couple of concerns about bumping moq version up because of this and this. It seems, right now it still safe to update.

Also, we have some local issues with tests in the repo. They are failing right now without clear reason. As soon as I make sure that everything OK, I'll merge it.

NikolayPianikov commented 7 months ago

Everything looks fine, let's merge it. However, it's necessary to resolve conflicts before merge

done