JetBrains / UnrealLink

Apache License 2.0
132 stars 23 forks source link

Riderlink won't build UE5 C++17 even with _SILENCE_ALL_CXX17_DEPRECATION_WARNINGS #130

Closed chadmv closed 2 years ago

chadmv commented 3 years ago

I have Rider for Unreal Engine 2021.2 Build #RDCPPP-212.4746.131, built on August 6, 2021 Non-Bundled Plugins: unreal-link (2021.2.0.603), com.microsoft.vso.idea (1.161.2)

I am trying to build with UE5-main ad5808d

I saw the issue in #109 and can see in the RD.Build.cs it has PublicDefinitions.Add("_SILENCE_ALL_CXX17_DEPRECATION_WARNINGS");

However I can't build Riderlink as I still see a bunch of C++17 errors. The messages all say to add the _SILENCE_ALL_CXX17_DEPRECATION_WARNINGS definition which I see is already defined. Any suggestions?

idea.log

chadmv commented 2 years ago

Issue seems to have been resolved at least as of 71b1485. The warnings still appear though.