search

JetBrains / UnrealLink

Apache License 2.0
132 stars 23 forks source link

Can't install newest rider link when using UE 4.23. #135

Closed RandomInEqualities closed 2 years ago

RandomInEqualities commented 2 years ago

Hi. The RightChopInline function is not present in UE 4.23 so it fails to compile the plugin. It also looks like there is some issue with 'LoggingScheduler':

` RiderLoggingExtension.hpp(26): error C2143: syntax error: missing ';' before '<'

RiderLoggingExtension.hpp(26): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int

RiderLoggingExtension.hpp(26): error C2238: unexpected token(s) preceding ';'

RiderLoggingExtension.cpp(77): error C2039: 'RightChopInline': is not a member of 'FString'

WindowsCriticalSection.h(9): note: see declaration of 'FString'

RiderLoggingExtension.cpp(105): error C2065: 'LoggingScheduler': undeclared identifier

RiderLoggingExtension.cpp(121): error C2065: 'LoggingScheduler': undeclared identifier `

(this is when using Visual Studio 2019)

ddimkovikj commented 2 years ago

I'm experiencing the same using

RiderLoggingExtension.cpp(77): error C2039: 'RightChopInline': is not a member of 'FString'

Any info where to find the compatible Unreal/Rider link for UE 4.24.3?

ddimkovikj commented 2 years ago

@DecoyRS this appears to be the commit that broke backwards compatibility with UE 4.23 and 4.24. At least regarding to 'RightChopInline'.

ddimkovikj commented 2 years ago

Found a way around this bug and was able to successfully connect Rider with UE 4.24. The workaround is to not to use the latest version of Rider for Unreal Engine, but the one before it - 2021.2. This version does not have the abovementioned commit that broke the backwards compatibility with UE 4.24, will build, install the RiderLink to the UE and successfully connect to it.

DecoyRS commented 2 years ago

Hello folks, Thank you for the feedback. The fix will be available on Monday.

DecoyRS commented 2 years ago

Fixed in https://plugins.jetbrains.com/plugin/14989-unreallink/versions/stable/140752

RandomInEqualities commented 2 years ago

Hi, Thanks for the fix. I think the include in UE 4.23 is "Templates/UniquePtr.h" for unique ptr. It fails to compile with this error for me atleast:

RiderLink\Source\RiderLoggingExtension\Private\RiderLoggingExtension.hpp(5): fatal error C1083: Cannot open include file: 'UniquePtr.h': No such file or directory