search

JetBrains / UnrealLink

Apache License 2.0
132 stars 23 forks source link

Failed to build RiderLink v2021.3.0.271 #154

Closed carl-haven closed 2 years ago

carl-haven commented 2 years ago

When trying to upgrade the RiderLink plugin from 2021.3.0.2 to 2021.3.0.271 we get the following error:

AppData\Local\Temp\UnrealLink\Boxomic\HostProject\Plugins\RiderLink\Source\RD\src\rd_framework_cpp\src\main\wire\SocketWire.cpp(119): error C2220: the following warning is treated as an error
    AppData\Local\Temp\UnrealLink\Boxomic\HostProject\Plugins\RiderLink\Source\RD\src\rd_framework_cpp\src\main\wire\SocketWire.cpp(119): warning C4267: 'argument': conversion from 'size_t' to 'const T', possible loss of data

Looking at the code SocketWire.cpp line 119 is missing a static_cast<int32_t>

ArtemiyAAA commented 2 years ago

Hello, @carl-haven Thanks for feedback! The issue fixed https://youtrack.jetbrains.com/issue/RIDER-73850. Please try latest commit https://github.com/JetBrains/UnrealLink/commit/e5233121e3ade37b152acd1a02f55eb1303ac4cf