search

JetBrains / aspire-plugin

.NET Aspire Plugin for JetBrains Rider
https://plugins.jetbrains.com/plugin/23289-aspire
MIT License
58 stars 0 forks source link

Better Notification When Docker Daemon is not started #262

Open khalidabuhakmeh opened 5 days ago

khalidabuhakmeh commented 5 days ago

Describe the bug

Folks might have turned off their Docker Daemon and tried to start the Aspire App Host with container integrations, leading to a "quiet" failure. Only after going to the Services window do folks see the failure in the output.

To Reproduce Steps to reproduce the behavior:

  1. Turn off Docker Daemon
  2. Attempt to start the AppHost run configuration
  3. Quiet failure
  4. See error

Expected behavior

Expect Rider to notify me/check that the Docker Daemon is required and not running. There are several options for UI/UX here.

  1. Wait for a fail message in the output and report that to users
  2. Check the Docker Daemon before running the run configuration

Screenshots

image001131-2024-10-02 -09-02-11

rafaelldi commented 4 days ago

I'm not sure about this. Tbh, DCP doesn't give us any information about containers, only about .NET projects. Obviously we can parse the source code and build the same model ourselves, but that might take a lot of work. Also, we can't always tell if Docker daemon is active or not, only if our Docker plugin is installed and connected to daemon. And, as far as I understand, IDE integration should only be responsible for .NET projects, everything else is a DCP thing.

khalidabuhakmeh commented 3 days ago

Maybe this is an enhancement to the IntelliJ platform, allowing plugins to potentially watch for text that comes through the IO found in the run window and surface it in the form of a notification.