Refactor API for DesktopScreenshotTestRule

JetBrains / compose-multiplatform

Compose Multiplatform, a modern UI framework for Kotlin that makes building performant and beautiful user interfaces easy and enjoyable.

https://jetbrains.com/lp/compose-multiplatform

Apache License 2.0

15.92k stars 1.16k forks source link

Refactor API for DesktopScreenshotTestRule #1041

Open igordmn opened 3 years ago

igordmn commented 3 years ago

Compose 1.0.0-alpha3

Currently it contains implementation details which shouldn't be public (like GoldenConfig).

We probably need to mark DesktopScreenshotTestRule as experimental.

Also DesktopScreenshotTestRule doesn't contain anything regarding Compose. Is it right that we have it as a public API in Compose? Should we move it to skiko?

okushnikov commented 3 weeks ago

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.