search

JetBrains / compose-multiplatform

Compose Multiplatform, a modern UI framework for Kotlin that makes building performant and beautiful user interfaces easy and enjoyable.
https://jetbrains.com/lp/compose-multiplatform
Apache License 2.0
16.24k stars 1.18k forks source link

Incorrect path for app image (in higher JDK versions?) #1712

Closed Thomas-Vos closed 1 month ago

Thomas-Vos commented 2 years ago

When creating a pkg using packagePkg task, after installation on my Mac it is installed like this: image

This is incorrect, should not be in a subfolder.

Maybe it's only for the newer JDK version, not sure. This was with JDK 17.

I originally found the issue while working on https://github.com/JetBrains/compose-jb/pull/1613. Because this bug would cause the build to fail completely in that case.

I added a workaround for building with appStore = true:

https://github.com/JetBrains/compose-jb/blob/ca382431c57f76e48ca27be531b3898879ae556b/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/desktop/application/tasks/AbstractJPackageTask.kt#L304-L309

However, the screenshot shown in this issue is without building for the app store, so the workaround should be extended to all build/packages.

Maybe it's only an issue for a certain JDK version. Not sure if any other platforms have this issue.

Thomas-Vos commented 2 years ago

@AlexeyTsvetkov

realrubbish commented 7 months ago

I am still experiencing this issue, when I install my application from the pkg file built with buildPkg it is installed into /Applications/app/Myapp.app subfolder instead of /Applications/Myapp.app (without appStore = true)

Is there a solution or a workaround?

okushnikov commented 2 months ago

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.