JetBrains / compose-multiplatform

Compose Multiplatform, a modern UI framework for Kotlin that makes building performant and beautiful user interfaces easy and enjoyable.
https://jetbrains.com/lp/compose-multiplatform
Apache License 2.0
16.34k stars 1.18k forks source link

Update the default app icons #2462

Closed mahozad closed 2 months ago

mahozad commented 2 years ago

Please update the default icons used for app executables if no icon is provided by the developer.

The current icons contain Kotlin logo (its old version).

I can create a pull request if you'd like (have not tested the .icns file).

compose-logo

Old New
3 4
1 2
igordmn commented 2 years ago

We will change the icon to the new Kotlin icon.

mahozad commented 2 years ago

@igordmn Wouldn't it be better to use the Compose Multiplatform logo?

And how about removing the background white container (and also the transparent padding)? I think this is something done more for Android apps. Doing it for Windows icon makes it so small:

Screenshot (124)

I should also mention that the existing .ICO file contains 128x128 size which may not be needed and makes the file unnecessarily large. The standard sizes for an exe icon can be found here.

And while we are at it, how about Compose Gradle plugin taking only a vector (SVG) image and automatically generating the proper icons for different platforms?

igordmn commented 2 years ago

Wouldn't it be better to use the Compose Multiplatform logo?

There are more obstacles for that - discussing with Google, and deciding which icon should be used. There is the separate blue icon for other Compose's than Jetpack Compose (you can see it on this page), which can be not look good in small scale and on different backgrounds (but I am not sure).

taking only a vector (SVG) image

That will be great :). But I am not sure that we find resources to implement that in the near future. If you or someone else implements that, we'll gladly review it, and merge if everything is okay.

Akhil-Hothi commented 8 months ago

How can we replace the default icon with custom icon in desktop? I am on windows and .exe file has kotlin logo as shown in image.

ivakub commented 3 months ago

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.