JetBrains / compose-multiplatform

Compose Multiplatform, a modern UI framework for Kotlin that makes building performant and beautiful user interfaces easy and enjoyable.
https://jetbrains.com/lp/compose-multiplatform
Apache License 2.0
16.21k stars 1.17k forks source link

compose/README.md says JDK 11, but the build expects JDK 17 #2826

Closed OliverO2 closed 1 month ago

OliverO2 commented 1 year ago

Describe the bug Trying the build as described in compose/README.md:

androidx/benchmark/gradle/Adb has been compiled by a more recent version of the Java Runtime

Affected platforms Select one of the platforms below:

Versions

dima-avdeev-jb commented 1 year ago

Thanks! This instruction is useful for contributors of Compose Multiplatform. In my environment, it is also works with JDK 11. But for that, you also need to follow another steps of this README, like this:

[macOs/Linux] Android SDK downloaded via ./compose/frameworks/support/jbdeps/android-sdk/downloadAndroidSdk

OliverO2 commented 1 year ago

Interesting. I did follow the other step and downloaded the SDK and still got the above error. Wondering what the difference might be.

I remember correctly, these are the steps I took:

Download submodules after downloading the main project:

IntelliJ IDEA 2022.3.2 (Ultimate Edition)
Build #IU-223.8617.56, built on January 26, 2023
Runtime version: 17.0.5+1-b653.25 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.

General requirements

Other steps taken

dima-avdeev-jb commented 1 year ago

Thanks for this research! We will check it! What OS do you have?

OliverO2 commented 1 year ago

Ubuntu 20.04.5 LTS (yes, I'm lazy with upgrading this one).

dima-avdeev-jb commented 1 year ago

@OliverO2 So, with JDK17 your development environment works well?

dima-avdeev-jb commented 1 year ago

I think soon we will update this doc to use JDK17 and newer.

OliverO2 commented 1 year ago

So, with JDK17 your development environment works well?

Yes, so far it does. I have successfully ported compose-counting-grid to Wasm as you can see in this Slack thread. Somewhat hacky, but I was able to integrate it as another example next to compose-jb/compose/frameworks/support/compose/mpp/demo.

okushnikov commented 3 months ago

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.