Context menu lacks some capabilities

adrientetar commented 1 year ago

Right now, only the colors of DefaultContextMenuRepresentation can be customized. It would be nice to be able to customize the margins and text size etc. of both the menu and the menu items.
- For the menu, it could take a modifier parameter applied to the Column inner composable.
- For the menu item, perhaps ContextMenuItem should take a composable content lambda instead of a string label.
Right now, it's not possible to display an icon or a keyboard shortcut in the menu. It is spec'ed in Material Design context menus, though:
Right now, it's not possible to add a divider to a context menu (and customize divider styling), see #1357
Right now, it's not possible to have a disabled menu item
Right now, it's not possible to add an item with a submenu
Styling:
- Right now, the shadow looks larger/more diffuse than in the Material spec.
- The menu item hover color is quite dark in light mode, I think it's a lighter color in the Material spec.
- I think it would be nice to add more corner rounding, like in the Material 3 spec (it would match the current desktop UI trends better).

m-sasha commented 1 year ago

Thanks, we'll discuss this with the team.

adrientetar commented 1 year ago

@m-sasha have any update on the discussion?

m-sasha commented 1 year ago

I apologize for taking a long time; we were busy with M1 and Kotlinconf. And now our team lead is on vacation, so unfortunately it'll take a little longer.

m-sasha commented 1 year ago

Hi. So, these suggestions are good, but right now we're focusing on other issues for the desktop. We should, however, add material3 soon-ish, which should address some of the requests here. And of course, we will get to polishing our context menu APIs some time.

dzirbel commented 10 months ago

In the meantime, I've put together a library that adds quite a bit of this missing functionality (icons, dividers, sub-menus, styling, etc): https://github.com/dzirbel/compose-material-context-menu. I hope this can cover most use cases until the team can dedicate time toward the builtin representation.

I also ran into a few limitations along the way, which I'll raise in a separate issue for discussion.

PMARZV commented 1 month ago

a simple modifier in context menu and a composable function to ContextMenuItem would be awesome! It lacks customization and that rect shape looks terrible😅

JetBrains / compose-multiplatform

Context menu lacks some capabilities #2859