Open igordmn opened 1 year ago
I think lag is very important. It makes the experience of using an app less pleasant.
Usually it is noticible when we continuously change the state (for example, when we drag something). When we change the state once (change indication on Release), it is probably can be noticible too, but less.
Also, I am not sure, if we have a lag in a real application, when frames render on each vsync, not continuously.
@igordmn is this maybe the cause for the application lag I notice every time I hover over multiple buttons?
Simple reproduction steps:
Tested it on Windows and noticed in a few applications already that I assume are written in Compose (JetBrains Toolbox and Fleet as well as my own Compose MPP apps). I was noticing a reduced pointer trail on these windows at first.
Compose 3fb4c2f7
After https://android-review.googlesource.com/c/platform/frameworks/support/+/2242251, the
ComposeSceneTest.rendering of clickable
fails in this line:It is because of this change:
The frame rendering was scheduled before we
pressScope.release()
, and because of that we render one frame beforepressScope.release()
.Not sure, if it is needed to be fixed for real-world cases. maybe in some cases, where application developer tighttly controlled the state of the application (we send an event -> we need to change the screenshot immediately to save it somewhere)