search

JetBrains / compose-multiplatform

Compose Multiplatform, a modern UI framework for Kotlin that makes building performant and beautiful user interfaces easy and enjoyable.
https://jetbrains.com/lp/compose-multiplatform
Apache License 2.0
16.3k stars 1.18k forks source link

ModalBottomSheet doesn't seem to respect WindowInsets #3795

Closed chrisjenx closed 1 year ago

chrisjenx commented 1 year ago

Describe the bug

ModalBottomSheet does not respect window insets correctly, it will inset double the keyboard height even when WindowInsets are set to (0) or systemBars only etc (See image)

Affected platforms

If the bug is Android-only, report it in the Jetpack Compose tracker

Versions

To Reproduce Steps and/or the code snippet to reproduce the behavior: Add ModalBottomSheet Add TextField Focus text field for soft keyboard See modal be pushed up double keyboard height

Expected behavior ModalBottomSheet, should respect correct window insets.

Screenshots Screenshot_1696910379

Additional context

Looks like this might have been addressed in Compose M3 1.2.0-alpha02

elijah-semyonov commented 1 year ago

Google owns the Android specific implementation. Could you please create a ticket here?

chrisjenx commented 1 year ago

Sure

On Tue, Oct 10, 2023 at 2:00 AM Elijah Semyonov @.***> wrote:

Google owns the Android specific implementation. Could you please create a ticket there https://issuetracker.google.com/issues/new?component=612128&template=1253476 ?

— Reply to this email directly, view it on GitHub https://github.com/JetBrains/compose-multiplatform/issues/3795#issuecomment-1754625332, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI5DMNLVPWXTT4BCFCETZLX6T6C7AVCNFSM6AAAAAA5ZV3CQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJUGYZDKMZTGI . You are receiving this because you authored the thread.Message ID: @.***>

elijah-semyonov commented 1 year ago

Thanks! Can you give me a ticket link so I can attach it to this issue and close it?

chrisjenx commented 1 year ago

I will close out until I can do a better bug report for you

Argamm commented 1 year ago

Hi everyone. I have the same problem with using ModalBottomSheet. Can anyone help me to solw it? Thanks!

okushnikov commented 2 months ago

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

chrisjenx commented 2 months ago

@Argamm I haven't tried since using the updated compose, they fixed a bunch of stuff in 1.7 and 1.3 Compose and M3 respectively so might be worth trying again