Bad recomposition after upgrade 1.5.12 -> 1.6.0

[Lukaszz112]

After compose upgrade from 1.5.12 to 1.6.0 my iOS screens are not recomposing correctly.

• iOS

Versions

• Kotlin version*: 1.9.21
• Compose Multiplatform version*: 1.6.0
• OS version(s)* (required for Desktop and iOS issues): ios 17.0.1
• OS architecture (x86 or arm64): arm64
• Device (model or simulator for iOS issues): simulator iPhone 15

To Reproduce iOS Code snippet:

struct ContactView {
  @State var isGoingToSubjectSearchView = false
  @Environment(\.presentationMode) private var presentationMode
}
extension ContactView: View {
  var body: some View {
    VStack {
      ComposeViewControllerToSwiftUI(factory: ContactUiViewControllerKt
        .ContactUiViewController(
          navigateBackAction: {
            presentationMode.wrappedValue.dismiss()
          },
          navigateToTopicSearchAction: {
            isGoingToSubjectSearchView = true
          }
        )
      )
    }.navigationBarBackButtonHidden(true)
      .ignoresSafeArea(.all, edges: .bottom)
    NavigationLink(isActive: $isGoingToSubjectSearchView) {
      ContactSubjectSearchView()
    } label: {
      EmptyView()
    }
  }
}

struct ContactSubjectSearchView {
    @Environment(\.presentationMode) private var presentationMode
}
extension ContactSubjectSearchView: View {
    var body: some View {
        VStack {
            ComposeViewControllerToSwiftUI(factory: ContactSearchSubjectUiViewControllerKt
                .ContactSearchSubjectUiViewController(
                    navigateBackAction: {
                        presentationMode.wrappedValue.dismiss()
                    }
                )
            )
        }.navigationBarBackButtonHidden(true)
    }
}
struct ComposeViewControllerToSwiftUI: UIViewControllerRepresentable {
    let factory: UIViewController
    func makeUIViewController(context: Context) -> UIViewController {
        factory
    }
    func updateUIViewController(_ uiViewController: UIViewController, context: Context) {
    }
}

Kotlin code:

fun ContactUiViewController(
    navigateBackAction: () -> Unit,
    navigateToSubjectSearchAction: () -> Unit
): UIViewController = ComposeUIViewController {
    println("hello ComposeUIViewController")
    CompositionLocalProvider(LocalAppDimensions provides phoneDimens) {
        println("hello provider")
        MyTheme {
            println("hello theme")
            UserProfileContactScreen(
                viewModel = getViewModel { getUserProfileContactViewModeliOSExt() },
                navigateToSubjectSearchAction = navigateToSubjectSearchAction,
                onBackAction = navigateBackAction,
            )
            println("hello Done")
        }
    }
}

Expected behavior Screens are recomposing correctly

Video below

https://github.com/JetBrains/compose-multiplatform/assets/93291505/40972827-c364-44bf-b2d8-f43ff5f96428

[elijah-semyonov]

@Lukaszz112 Hi, thanks for the report. I struggle to recognise the problem. What did you specifically expect to happen, recomposition on navigating back to the second ViewController?

[Lukaszz112]

@elijah-semyonov I want to relaunch ViewController. There are some logs, look on thier behavior. After navigating back to the previous viewController its not recomposing, and viewModel onStart method isnt called. It was working on 1.5.12

[elijah-semyonov]

It was a bug of 1.5.12, it was not supposed to recompose, the state didn't change. If you need to perform some logic on appearance of ComposeUIViewController, check the ComposeUIViewControllerDelegate API

[Lukaszz112]

okay thanks ill check

[okushnikov]

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.