[Wasm] isSystemInDarkTheme does not return a correct value

JetBrains / compose-multiplatform

Compose Multiplatform, a modern UI framework for Kotlin that makes building performant and beautiful user interfaces easy and enjoyable.

https://jetbrains.com/lp/compose-multiplatform

Apache License 2.0

16.15k stars 1.17k forks source link

[Wasm] isSystemInDarkTheme does not return a correct value #4637

Closed Nek-12 closed 6 months ago

Nek-12 commented 6 months ago

Describe the bug isSystemInDarkTheme() always returns false on wasm, even if the system is on dark mode (tested on MacOS Sonoma 14 Chrome)

Affected platforms

Web (K/Wasm) - Canvas based API

Versions

Kotlin version*: 1.9.23
Compose Multiplatform version*: 1.6.2 Chrome Version 124.0.6367.49 (Official Build) beta (arm64)

Expected behavior isSystemInDarkTheme returns a correct value and updates itself when the theme is changed.

Nek-12 commented 6 months ago

Pardon me for the mistake - the issue is different. Unlike Android, the app does not set the window background color automatically, hence, a Modifier.background() is required at the top level

okushnikov commented 3 months ago

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.