JetBrains / compose-multiplatform

Compose Multiplatform, a modern UI framework for Kotlin that makes building performant and beautiful user interfaces easy and enjoyable.
https://jetbrains.com/lp/compose-multiplatform
Apache License 2.0
16.31k stars 1.18k forks source link

iOS - Scroll does not work at all when touch starts on a UIKitView inside eg a LazyColumn #4818

Closed AttilaBarany closed 4 months ago

AttilaBarany commented 6 months ago

Affected platforms

Versions

To Reproduce Just extend the "uikit-in-compose" example app like this:

Screenshot 2024-05-16 at 16 15 51

(adding a big box after the elements inside the column, and make the column scrollable)

and try to scroll by grabbing eg the textfield

You can reproduce this with any UIKitView, eg a simple UIView(), wkwebview etc... Adding eg Androidview webview does allow us to scroll by grabbing it, but UKitView does not bubble up anything, even tried with custom nestedscrollconnection just print out pre- or post scroll, but got not a single trigger. This failure just makes useless the UIKitView, or at least very limited. You can just integrate only in static pages, without any scrolling, otherwise the user will stuck on the page with invisible contents which are below in the column.

brewin commented 6 months ago

Funny, I was just about to submit this same issue. It does severely limit the use of UIKitView. Setting interactive = false makes it scrollable, but of course then it isn't interactive.

Here is my minimal reproducer:

@OptIn(ExperimentalForeignApi::class)
fun MainViewController() = ComposeUIViewController {
    Column(modifier = Modifier.verticalScroll(state = rememberScrollState())) {
        UIKitView(
            factory = {
                UIView().apply {
                    backgroundColor = UIColor.redColor
                }
            },
            modifier = Modifier.fillMaxWidth().height(400.dp)
        )
        repeat(100) {
            Text("Item #$it")
        }
    }
}
elijah-semyonov commented 6 months ago

Hi, it's a known problem, and not exactly a trivial one to fix due to differences in touch processing in Compose and UIKit. We are investigating our options currently.

AttilaBarany commented 6 months ago

Great news, thank you @elijah-semyonov . I am gonna suspend my project until than, and stay with separated UI (I am using a webview in column, which can not be done without UIKitView for iOS).

elijah-semyonov commented 6 months ago

As a workaround, you could present native UIViewController with web view modally on top of compose UI. Use LocalUIViewController.current.

AttilaBarany commented 6 months ago

As a workaround, you could present native UIViewController with web view modally on top of compose UI. Use LocalUIViewController.current.

So how that would could be part of the scrollable content? I dont get it.

elijah-semyonov commented 6 months ago

It won't be. But you don't have to reimplement entire screen natively.

AttilaBarany commented 6 months ago

It won't be. But you don't have to reimplement entire screen natively.

Just the column content, get it. Which is the whole screen (except top and bottom bar).:) Never mind. I started and coded the UI already separately/natively, but wanted to refactor to only maintain one UI instead of two. Took almost 2 weeks, and this was the last piece which is missing, everything else looks working, thats why its so annoying :)) But I might keep going this direction and use this screen only natively as suggested.

Thanks for your help anyway, and I am looking forward to have this fixed. :) (p.s I beleive flutter had the very same issue before)

brewin commented 6 months ago

Flutter's UIKitView has a gestureRecognizers property that allows customizing the gestures that are passed to the UIKit view.

https://api.flutter.dev/flutter/widgets/UiKitView/gestureRecognizers.html

For example, with the following setup vertical drags will not be dispatched to the UIKitview as the vertical drag gesture is claimed by the parent [GestureDetector].

GestureDetector(
  onVerticalDragStart: (DragStartDetails details) {},
  child: const UiKitView(
    viewType: 'webview',
  ),
)
elijah-semyonov commented 6 months ago

Well, we can do that! The problem is, there is no way that is currently apparent to us, to conditionally allow touches to slip to the interop view gesture recognisers (such as compose scroll in a native scroll, for example).

The behavior in your example is possible by the usage of Modifier.draggable and using interactable = false in UIKitView arguments.

dilip640 commented 5 months ago

facing same issue

vickyleu commented 5 months ago

same

kavindudiyes commented 5 months ago

@elijah-semyonov could you please expand on your suggestion of "The behavior in your example is possible by the usage of Modifier.draggable and using interactable = false in UIKitView arguments.". I tried a few combinations of setting interactive = false and implementing draggable on the Modifier, without success. With interactive = false, scrolling is fine, but it doesn't register any click events as @brewin has pointed out above.

My use-case is to embed a Native Ad using Google AdMob, where the UIView for the Ad is coming from Swift for iOS. In the ideal case, I want to be able to scroll on top of the Ad, but still be able to click on the Ad.

vickyleu commented 4 months ago

My solution is to turn off the touch event of UIView and unify the click penetration through the click event hitTest of compose to the rect of UIView.

For example, my UIView put a webview, and I need to click on the picture inside. I will first register a query of the coordinates of all pictures through js, get a set of rectangular arrays, and confirm that the picture is clicked by matching the array.

elijah-semyonov commented 4 months ago

Awaiting your feedback (and perhaps future issues) after these changes are released! Track release notes for iOS 🌚

okushnikov commented 4 months ago

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

AttilaBarany commented 4 months ago

@elijah-semyonov I have imported 1.7.0-dev1727, But I do not experience any difference. The same lazycolumn which holds a wkwebview or a single uiview, does not scroll if the drag starts on the UIKitview (Modify.draggable also not triggered). But it does scroll with Androidview.

paskowski commented 4 months ago

I also see no difference when running 1.7.0-dev1727. In my case it's lazy column with UIKitView that has UITextField inside of it.

elijah-semyonov commented 4 months ago

@AttilaBarany @paskowski You need to move a finger over the screen fast to recognise a scroll

AttilaBarany commented 4 months ago

@AttilaBarany @paskowski You need to move a finger over the screen fast to recognise a scroll

Nothing happens. Slow, fast, long, short, delay...

Screenshot 2024-07-15 at 14 18 04
brewin commented 4 months ago

I don’t think 1.7.0-dev1727 includes the changes. The next dev release will.

AttilaBarany commented 4 months ago

I don’t think 1.7.0-dev1727 includes the changes. The next dev release will.

I got it from his commit linked in this issue above. https://github.com/JetBrains/compose-multiplatform-core/commit/174766b50bf9fda2aa04a4a276026f6ee6bd9d5f

Screenshot 2024-07-15 at 14 45 49
elijah-semyonov commented 4 months ago

@AttilaBarany Please provide a full repro project, I can't reproduce your behavior from a snippet:

val factory = remember {
    {
        UIView().apply {
            backgroundColor = UIColor.blueColor
            userInteractionEnabled = true
        }
    }
}

LazyColumn(modifier = Modifier.fillMaxSize()) {
    item {
        UIKitView(
            modifier = Modifier.fillMaxWidth().height(300.dp),
            factory = factory
        )
    }

    item {
        Box(Modifier.fillMaxWidth().height(1500.dp).background(Color.Red))
    }
}

https://github.com/user-attachments/assets/4a2702cd-2683-4e37-87a0-a5cd3e2e1bf2

elijah-semyonov commented 4 months ago

The logic is identical to UIScrollView now - if there is fast initial movement, gesture is recognised as scroll and dispatched accordingly. If there is no movement and hitTest is an interop view, it intercepts the touches and no scrolling will ever happen until touches sequence ends (all fingers are up)

paskowski commented 4 months ago

I agree with https://github.com/JetBrains/compose-multiplatform/issues/4818#issuecomment-2228420632 that https://github.com/JetBrains/compose-multiplatform/releases/tag/v1.7.0-dev1727 does not have the changes that were supposed to fix this issue.

AttilaBarany commented 4 months ago

@elijah-semyonov The video looks very promising, thank you for testing and showing me the error maybe is in my setup!!! I had a mistake providing the library version. I have changed the lib to 1.7.0-dev1727, but the gradle was set to use the compose.plugin which had an earlier version set. After fixed (set the plugin version to 1.7.0-dev1727), or I thought I fixed, gradle does not want to sync: Could not find org.jetbrains.compose.runtime:runtime:1.7.0-dev1727. Required by: project :shared

AttilaBarany commented 4 months ago

@elijah-semyonov I got the versions sorted, I set 1.7.0-alpha01 whis is the latest, and the scroll still does not work. So @paskowski and @brewin are correct. The fix is still not included.

Screenshot 2024-07-15 at 20 37 04
elijah-semyonov commented 4 months ago

That's super awkward, CI shows that it was included in 1727. Anyway, let's w8 for other dev build and see if it flies.

MatkovIvan commented 4 months ago

I got the versions sorted, I set 1.7.0-alpha01 whis is the latest,

1.7.0-dev1727 is newer than 1.7.0-alpha01. 1.7.0-alpha01 does not contain @elijah-semyonov 's fix, but dev1727 does. devXXXX is regular builds from master that are not uploaded to maven central (available only from dev one), so sorting is not really correct here. We might improve naming in the future, but now it is what it is.

paskowski commented 4 months ago

I can confirm that both 1.7.0-dev1727 and 1.7.0-dev1731 work correctly. I think I set an incorrect dependency's version yesterday, apologies for that. Thank you for fixing this, it's a real game changer @elijah-semyonov 🎉 .

yuroyami commented 3 months ago

This broke one of the things that used to work fine. I am wrapping an (native iOS) eBook reader (which is basically a UIViewController) which internally responds to gestures, especially tap gestures. I am wrapping that UIViewController in Compose:

@OptIn(ExperimentalForeignApi::class)
@Composable
fun ReadiumViewport(c: UIViewController) {
    UIKitViewController(
            factory = { obtainReadiumController() },
            modifier = Modifier.fillMaxSize()
     )
}

It used to scroll, tap, pinch in/out fine, but now it's not responding to touches at all. It seems like Compose is preventing all gestures from propagating to the UIViewController itself. I am not sure why this is happening because I am not setting any external Compose tap listeners. All the gesture listening is happening internally inside the UIViewController itself.

elijah-semyonov commented 3 months ago

@yuroyami We'll provide opt-out to previous behavior. Implementation is already there, just wait a bit for API addition.

AttilaBarany commented 3 months ago

@elijah-semyonov the problem looks solved and perfect on published 1.7.0-alpha02. Thanks very much, now it acts how android does.

elijah-semyonov commented 3 months ago

@AttilaBarany You are welcome. Please don't hesitate to post other issues and proposals on our issue tracker.

vickyleu commented 3 months ago

@elijah-semyonov I can confirm that compose 1.7.0 xxx has disrupted the scrolling event of webview in UIKitView, 1.6.11 work well compose-webview-multiplatform

elijah-semyonov commented 3 months ago

You just need to hold your finger still for 150ms before scrolling. An opt-out to previous behavior is in https://github.com/JetBrains/compose-multiplatform-core/pull/1494

mndsl commented 2 months ago

I have tried all the 1.7xxx versions (dev too) and none of them works as expected. I'm using UIKitView to display PDFView, the view reacts to taps and double taps, but it's impossible to scroll the pages of the pdf documents. As other have mentioned, webview and MKMapView does not work either. Altogether, every view inside UIKitView, that needs to scroll can't scroll. There are no nested scrolls, nor click modifiers... 1.6.11 used to work perfectly, unfortunately we can't rollback to it as it has other bugs. Please fix this, it's vital part from a very large multiplatform app we are developing, and with this bug is impossible to publish the app.

brewin commented 2 months ago

They are working on improving interop.

https://youtrack.jetbrains.com/issue/CMP-5875/iOS-interop-epic

mekutluca commented 1 week ago

In version 1.7.0, this worked for me: (Notice that I've selected interaction mode as NonCooperative)

UIKitView(
        factory = {
            PDFView()
        },
        modifier = Modifier.fillMaxSize(),
        update = { view ->
            view.autoScales = true
            view.document = NSData.create(base64Encoding = encodedString)?.let { data ->
                PDFDocument(data = data)
            }
        },
        properties = UIKitInteropProperties(
            isNativeAccessibilityEnabled = true,
            interactionMode = UIKitInteropInteractionMode.NonCooperative,
        ),
    )
MatkovIvan commented 1 week ago

Please check the following ticket on YouTrack for follow-ups to this issue