search

JetBrains / compose-multiplatform

Compose Multiplatform, a modern UI framework for Kotlin that makes building performant and beautiful user interfaces easy and enjoyable.
https://jetbrains.com/lp/compose-multiplatform
Apache License 2.0
15.24k stars 1.11k forks source link

[iOS/ImageViewer] Proposal of Fix share image button infinite loop #4973

Closed issamux closed 1 day ago

issamux commented 1 week ago

Proposal of a Fixes ( Unfortunately, I can't test the rest of the code as the iOS camera requires a real device. )

Fixes https://github.com/JetBrains/compose-multiplatform/issues/4970

mazunin-v-jb commented 5 days ago

@issamux Thanks for your contribution! Looks good to me. I've checked on a real device too, works fine. Why is it in draft status?

issamux commented 4 days ago

@issamux Thanks for your contribution! Looks good to me. I've checked on a real device too, works fine. Why is it in draft status?

@mazunin-v-jb in draft status because " NSURL.readData(): NSData " code is used in all camera code and as I said i can't test on real device... otherwise PR is ready :)

Thanks :)