JetBrains / compose-multiplatform

Compose Multiplatform, a modern UI framework for Kotlin that makes building performant and beautiful user interfaces easy and enjoyable.
https://jetbrains.com/lp/compose-multiplatform
Apache License 2.0
16.01k stars 1.16k forks source link

Compose Multiplatform and Jetpack Compose method signatures are inconsistent. #5004

Closed Junzz0 closed 3 months ago

Junzz0 commented 3 months ago

Describe the bug Compose Multiplatform and Jetpack Compose method signatures are inconsistent.

Affected platforms

Versions

To Reproduce Steps to reproduce the behavior: https://github.com/JetBrains/compose-multiplatform-core/blob/jb-main/compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationBar.kt https://github.com/JetBrains/compose-multiplatform-core/blob/jb-main/compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt https://github.com/JetBrains/compose-multiplatform-core/blob/jb-main/compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationRail.kt

https://github.com/androidx/androidx/blob/androidx-main/compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationBar.kt https://github.com/androidx/androidx/blob/androidx-main/compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt https://github.com/androidx/androidx/blob/androidx-main/compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationRail.kt

Compose Multiplatform is interactionSource: MutableInteractionSource = remember { MutableInteractionSource() } Jetpack Compose is interactionSource: MutableInteractionSource? = null,

4952

Expected behavior Expectations are consistent with upstream.

MatkovIvan commented 3 months ago

Last released multiplatform version of material3 is based on 1.2.1

Adopting 1.3 betas is in progress. Closing as duplicate of #4849

okushnikov commented 1 month ago

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.